Chm02 CUDA: mainline correctness fixes, tests, and timing surface#84
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 302f13b036
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79
Summary
This PR mainlines the validated
Chm02CUDA bring-up work as a focused correctness-first integration slice.It promotes the legacy
Chm02CUDA path from a CPU-assisted bring-up flow toward a first-class correctness path for single-graph runs by moving the major solve phases onto the GPU, fixing Linux compatibility issues, adding focused regression coverage, and exposing explicit CUDA timing fields.Included
Graph.cu/GraphCu.cfixes for CUDA add-keys, peel/order capture, assignment, and verify.Chm02Compat/ file-work fixes needed for no-file-io and file-io parity.Chm02:Assigned16casedocs/chm02-cuda-mainline.mddescribing scope, non-goals, compatibility notes, and staged acceptance.Non-goals
Chm02CUDA kernels.Validation
Ran:
cmake --build build-cuda -j2ctest --test-dir build-cuda --output-on-failure -R 'perfecthash\.cuda\.chm02'Current focused CUDA
Chm02test result:Notes
This remains a correctness-first CUDA path. The serial CUDA kernels are intentionally bring-up oriented and should not be read as a throughput claim.